Skip to content

Remove #[ignore] from mainnet fork tests#927

Merged
3alpha merged 1 commit intomainfrom
remove-ignore-mainnet-tests
Apr 20, 2026
Merged

Remove #[ignore] from mainnet fork tests#927
3alpha merged 1 commit intomainfrom
remove-ignore-mainnet-tests

Conversation

@3alpha
Copy link
Copy Markdown
Collaborator

@3alpha 3alpha commented Apr 20, 2026

Usage related changes

N/A

Development related changes

Removes the #[ignore] attribute and TODO comments from 4 mainnet fork integration tests:

  • get_events_from_forked_devnet_when_last_queried_block_on_origin
  • get_events_from_forked_devnet_when_first_queried_block_on_origin_and_last_on_devnet
  • get_events_since_accepted_on_l1_on_origin
  • test_fork_subscription_to_old_blocks_should_fail

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR
  • Updated the tests if needed; all passing

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 439b513a-b4aa-4928-b88f-29db0b08f46b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'auto_resolve_threads'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-ignore-mainnet-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@3alpha 3alpha merged commit bf3428b into main Apr 20, 2026
6 checks passed
@3alpha 3alpha deleted the remove-ignore-mainnet-tests branch April 20, 2026 12:04
@3alpha 3alpha mentioned this pull request Apr 23, 2026
9 tasks
@3alpha 3alpha added the testing Related to code testing label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Related to code testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant